Reserve cores 0 and 1 for the OS#2851
Merged
Merged
Conversation
gefjon
approved these changes
Jun 10, 2025
Contributor
|
Shouldn't this be handled on the OS level instead? What about the case when running irqbalance? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
This patch makes it so that we do not pin any threads to core IDs 0 and 1, and instead reserve them for the OS. See the comment for more explanation.
API and ABI breaking changes
None
Expected complexity level and risk
1
A very simple change, but because we are taking cores away from the database we may need to change the distribution of the remaining cores.
Testing
Before this change we saw the OS preempting reducer threads to handle interrupt requests, after this change - along with mapping these interrupt handlers to the reserved cores - we did not.